feat(radar): export radar data #2981
Merged
+321
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Jan 14, 2025
maidul98
reviewed
Jan 14, 2025
6 tasks
frontend/src/pages/organization/SecretScanningPage/SecretScanningPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/organization/SecretScanningPage/components/ExportResultsModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/organization/SecretScanningPage/components/ExportResultsModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/organization/SecretScanningPage/components/ExportResultsModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/organization/SecretScanningPage/components/ExportResultsModal.tsx
Outdated
Show resolved
Hide resolved
|
we should add handling for when exported data is empty. maybe show an appropriate modal? |
sheensantoscapadngan
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces support for exporting radar secret scans to CSV or JSON. It supports filtering for status (all, resolved, or unresolved), github organization, and github repository.
@akhilmhdh We found an issue where the
installation_idquery parameter wouldn't get added to the parameters, even though it was included in the search validation. For now I've just entirely removed the search validation for the organization/secret-scanning endpoint. Please let me know your thoughts on this.Additionally Maidul and I have resolved a lot of issues with the Radar, that made it impossible to use for new users.
Type ✨